docs: say HttpHeaders stay on client-to-daemon calls - #7211
Open
locker95 wants to merge 1 commit into
Open
Conversation
Member
|
This doesn't look correct; headers are forwarded, but (currently) restricted to headers prefixed with Fake registry; dumps every request, including headers. docker run -d --quiet --rm --name registry-echo -e LOG_WITHOUT_NEWLINE=true -e DISABLE_REQUEST_LOGS=true -p 5001:8080 mendhak/http-https-echo:41Configure the client with custom headers and pull an image (this will fail because it's not an actual registry); DOCKER_CUSTOM_HEADERS='X-Meta-Test=forwarded,X-Test=not-forwarded' docker pull 127.0.0.1:5001/test:latestCheck the logs of the fake registry; docker logs -n2 registry-echo | jq .headers |
Author
|
yeah — i had that backwards. X-Meta-* is what gets forwarded on pull; the rest stays on the client-to-daemon request. updated. |
Member
|
Thanks for updating; could you squash the commits? |
HttpHeaders go on client-to-daemon calls. Names that start with X-Meta- are also passed through on pull and similar. Signed-off-by: Dean Chen <862469039@qq.com>
locker95
force-pushed
the
docs/httpheaders-client-only
branch
from
August 18, 2026 13:42
0a828d8 to
24a5213
Compare
Author
|
squashed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HttpHeaders in config.json sounded like they ride along on every request. they only go on CLI-to-daemon calls, not on the daemon's registry pulls.
See docker/docs#11456